Form Validation Failing - Not Consistent

Looking at the code you have provided: 

ReviewType == 'Available Capacity' && 
(
  isNullOrEmpty(trim(CustomerCompanyName)) || 
  isNullOrEmpty(trim(ResourceCenterDistrictLocation)) || 
  isNullOrEmpty(trim(StreetAddress)) || 
  isNullOrEmpty(trim(ZipCode)) || 
  isNullOrEmpty(trim(HourlyLoad)) || 
  isNullOrEmpty(HourlyLoadUnits) || 
  isNullOrEmpty(trim(DailyLoad)) || 
  isNullOrEmpty(DailyLoadUnits) || 
  isNullOrEmpty(trim(DeliveryPressurepsig))
)‍‍‍‍‍‍‍‍‍‍‍‍

The only thing that sticks out is the missing 'trim' functions from two of your arguments.

That being said, it might be a lot easier to figure out what's happening if you just gave each Control its own Rule written simply like: 

ReviewType === 'Available Capacity' && isNullOrEmpty(trim({Control:Self}))‍

Being that, that's all you seem to actually be checking for each one of these Controls. 

I guess maybe I'm not understanding something. 

• Could you maybe describe how / where you are applying the rule code from above?
• Are you putting that rule on all of your controls? 
• Do you also want to account for whatever values exist in the ReviewType control?
• You seem to suggest that the controls should be invalid if they are blank... if that's the case, then why does it matter what the value of ReviewType is? 

• Each individual control currently has not validation attached to them
  
  • I was going to see IF perhaps I could find a work around for the Blank space issue by adding a RegEX to the control itself...

You seem to be indicating that each control does not have validation set on it. If that is the case, do you just have (13) different rules all placed on a single control? Is that control the ReviewType control itself? If that's the case, how are you highlighting the controls that are 'invalid'? Either way, this approach could cause problems I'd imagine. 

Additionally, when you wrote the Rule were using the Item Property or the Named Control value from the Formula Builder? Selecting one over the other could cause all sorts of problems as the Item Property references the value of a Column in SharePoint as it is right now, while a Named Control references the value of the Form Control as named. 

Options for Review Type 

Home for all the Validations - Currently NONE on individual controls 

Interesting. 

I set up a test form with three 'ReviewType' options and a different rule (which was only on the ReviewType control), which allowed for three different configurations across its options. 

Everything worked the way that I would have expected it to with each option correctly invalidating the form if the control's required were not filled out. I have uploaded and attached my example form to this post. 

Due to how you have your own custom setup with your own custom javascript, I would highly recommend opening up the developer's console (using F12, use Chrome Browser if you can), and check to see if you are actually running into any errors anywhere in there which could prevent certain validation rules from being ran. 

Another suggestion would be to wrap your rule in a IIFE (Immediately Invoked Function Expression) like: 

(function() {
  
  var returnVal = (ReviewType == 'Option 1' && (isNullOrEmpty(trim(CustomerCompanyName)) ||
    isNullOrEmpty(trim(ResourceCenterDistrictLocation)) || 
    isNullOrEmpty(trim(StreetAddress)) || 
    isNullOrEmpty(trim(ZipCode)) || 
    isNullOrEmpty(trim(HourlyLoad)) || 
    isNullOrEmpty(HourlyLoadUnits) || 
    isNullOrEmpty(trim(DailyLoad)) || 
    isNullOrEmpty(DailyLoadUnits) || 
    isNullOrEmpty(trim(DeliveryPressurepsig))));

  console.log("Option 1 Evaluated to: " + returnVal);
  return returnVal
}())‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍‍

In this way you can at least throw in a 'debugger;' statement or just see what's happening in the dev console. 

----------

Last but not least, I'd recommend to just break the rules up across the individual controls instead of trying to lump them all together at the topmost level, with a bunch of additional code to style them in a custom way unless it's absolutely necessary or you're hitting some type of crazy performance wall. 

The only other thing I could think of would be for you to just upload your form, or an example form (that is experiencing the same problem) to the forums for us to check out. 

Going to use this one to test for the time being. Same thing happening but I will keep this one in test.

This one has two review types.

ReviewType=='Pressure Related ' && MAOPReviewSubtype=='Preliminary' && (isNullOrEmpty(ResourceCenterDistrictLocation) ||
 isNullOrEmpty(trim(AffectedLineNumberName)) ||
 isNullOrEmpty(trim(DesignMAOPpsig)) ||
 isNullOrEmpty(trim(IR)) ||
 isNullOrEmpty(trim(AssignedProjectManager)) ||
 isNullOrEmpty(trim(SignedG3)) ||
 isNullOrEmpty(ApprovedHydroTestRecordsforAllFacilities) ||
 isNullOrEmpty(AsBuiltBOM) ||
 isNullOrEmpty(SubmittedEmergencySchematic) ||
 isNullOrEmpty(SCADAScreensApprovedActive) ||
 isNullOrEmpty(FacilitiesVerifiedin811Database))

I did my own testing since I know the issues. 

It is consistent where ever the TRIM is used. The key is filling in the FIRST item in the list. Then once some of the other are filled in it will save. QA missed because they were probably filling in randomly and it's easy to miss on the options that have smaller required fields. 

First, make sure that there is no information in your Form's Settings that might be sensitive (urls, names, etc.), and then export the Form as shown: 

Here on the forums, instead of replying with the normal 'Quick' Editor, use the Advanced Editor option: 

On this screen you should be able to see the area highlighted which will allow you to upload your form: 

Finally had a chance to look at this during lunch. Nothing immediately popped out as problematic. I even used the rule how you had it written in the original topic post. 

Do you have a set of instructions that I can follow in which it will fail as it is failing for you? 

Perhaps indeed. I am currently running SharePoint 2016 with the latest ver of Workflow and Forms. Tested with both the trim and non-trimmed versions and had the same results. The biggest issues that I noticed is that the form tends to deform as you make your selections that Hide / Show content, which, at least for me, would sometimes cause a few controls to be hidden behind others.  

Here are a series of pictures showing the form from top to bottom. The highlighted area shows the problem in question. If you are not experiencing this in your environment, then I wouldn't worry about it. 

(Note that I have simply selected the top selection):

I think the glitch must be system related BUT this exercise with you helped me to settle on a solution vs trying to go in circles fixing something that may not be immediately "fixable".